build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41949 )
Change subject: soc/mediatek/mt8183: Support 6GB, 8GB DDR bootup ......................................................................
Patch Set 1:
(22 comments)
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/dra... PS1, Line 2736: dramc_show("RK%d size %dGb, density:%d\n", rk, (u32)(dram_size >> 27), max_density); line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 327: enum tRFCAB{tRFCAB_130 = 0, tRFCAB_180, tRFCAB_280, tRFCAB_380, tRFCAB_NUM}; missing space after enum definition
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 331: {{.trfc = 14, .trfrc_05t = 0, .trfc_pb = 0, .trfrc_pb_05t = 0, .tx_ref_cnt = 32}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 332: {.trfc = 24, .trfrc_05t = 0, .trfc_pb = 6, .trfrc_pb_05t = 0, .tx_ref_cnt = 42}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 333: {.trfc = 44, .trfrc_05t = 0, .trfc_pb = 16, .trfrc_pb_05t = 0, .tx_ref_cnt = 62}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 334: {.trfc = 64, .trfrc_05t = 0, .trfc_pb = 26, .trfrc_pb_05t = 0, .tx_ref_cnt = 82}}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 334: {.trfc = 64, .trfrc_05t = 0, .trfc_pb = 26, .trfrc_pb_05t = 0, .tx_ref_cnt = 82}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 336: {{.trfc = 27, .trfrc_05t = 0, .trfc_pb = 6, .trfrc_pb_05t = 0, .tx_ref_cnt = 46}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 337: {.trfc = 42, .trfrc_05t = 0, .trfc_pb = 15, .trfrc_pb_05t = 0, .tx_ref_cnt = 61}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 338: {.trfc = 72, .trfrc_05t = 0, .trfc_pb = 30, .trfrc_pb_05t = 0, .tx_ref_cnt = 91}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 339: {.trfc = 102, .trfrc_05t = 0, .trfc_pb = 45, .trfrc_pb_05t = 0, .tx_ref_cnt = 121}}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 339: {.trfc = 102, .trfrc_05t = 0, .trfc_pb = 45, .trfrc_pb_05t = 0, .tx_ref_cnt = 121}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 341: {{.trfc = 40, .trfrc_05t = 0, .trfc_pb = 12, .trfrc_pb_05t = 0, .tx_ref_cnt = 59}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 342: {.trfc = 60, .trfrc_05t = 0, .trfc_pb = 24, .trfrc_pb_05t = 0, .tx_ref_cnt = 79}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 343: {.trfc = 100, .trfrc_05t = 0, .trfc_pb = 44, .trfrc_pb_05t = 0, .tx_ref_cnt = 119}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 344: {.trfc = 140, .trfrc_05t = 0, .trfc_pb = 64, .trfrc_pb_05t = 0, .tx_ref_cnt = 159}}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 344: {.trfc = 140, .trfrc_05t = 0, .trfc_pb = 64, .trfrc_pb_05t = 0, .tx_ref_cnt = 159}}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 346: {{.trfc = 48, .trfrc_05t = 1, .trfc_pb = 16, .trfrc_pb_05t = 0, .tx_ref_cnt = 68}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 347: {.trfc = 72, .trfrc_05t = 0, .trfc_pb = 30, .trfrc_pb_05t = 0, .tx_ref_cnt = 92}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 348: {.trfc = 118, .trfrc_05t = 1, .trfc_pb = 53, .trfrc_pb_05t = 1, .tx_ref_cnt = 138}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 349: {.trfc = 165, .trfrc_05t = 0, .trfc_pb = 76, .trfrc_pb_05t = 1, .tx_ref_cnt = 185}}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/41949/1/src/soc/mediatek/mt8183/emi... PS1, Line 349: {.trfc = 165, .trfrc_05t = 0, .trfc_pb = 76, .trfrc_pb_05t = 1, .tx_ref_cnt = 185}}, space required after that close brace '}'