Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31179 )
Change subject: riscv: Simplify payload handling
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31179/2/src/arch/riscv/boot.c
File src/arch/riscv/boot.c:
https://review.coreboot.org/#/c/31179/2/src/arch/riscv/boot.c@45
PS2, Line 45: RISCV_PAYLOAD_MODE_S
If use bbl as rampayload, there should be RISCV_PAYLOAD_MODE_M
That's correct. For rampayload ENV_RAMSTAGE will be false as it's executed from the rom stage.
But we can add an explicit case for rampayload when it's added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31179
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32bf2a99e07a65358a7f19b899259f0816eb45e8
Gerrit-Change-Number: 31179
Gerrit-PatchSet: 2
Gerrit-Owner: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 01 Feb 2019 14:15:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xiang Wang
wxjstz@126.com
Gerrit-MessageType: comment