Attention is currently required from: Karthik Ramasubramanian, Shelley Chen.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79295?usp=email )
Change subject: mb/google/brox: Update storage settings for SSD and UFS ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/79295/comment/80ed26ea_eaf48346 : PS2, Line 382: /* GPP_F9 : [NF1: BOOTMPC NF6: USB_C_GPP_F9] ==> SSD_PERST_L */ : PAD_CFG_GPO(GPP_F9, 0, DEEP), : /* GPP_D11 : [] ==> EN_PP3300_SSD */ : PAD_CFG_GPO(GPP_D11, 1, DEEP), : /* GPP_S0 : SNDW0_CLL/I2S1_SCLK ==> MEM_CH_SEL */ : PAD_CFG_GPI(GPP_S0, NONE, DEEP), : /* F21 : EXT_PWR_GATE2# ==> NC */ : PAD_NC(GPP_F21, NONE), : /* H10 : UART0_RXD ==> UART_PCH_RX_DBG_TX */ : PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), : /* H11 : UART0_TXD ==> UART_PCH_TX_DBG_RX */ : PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2),
can you put these in order based on GPP_#?
Done.