build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )
Change subject: intel/common/mmc: Provide mmc.c for setting dll registers. ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/mmc.c:
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... PS1, Line 29: struct mmc_dll_params dll_params; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... PS1, Line 29: struct mmc_dll_params dll_params; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... PS1, Line 32: printk(BIOS_INFO, "Skip Emmc dll value programming \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... PS1, Line 34: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... PS1, Line 34: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35040/1/src/soc/intel/common/block/... PS1, Line 36: printk(BIOS_INFO, "Override emmc dll value \n"); unnecessary whitespace before a quoted newline