Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39465 )
Change subject: soc/intel/tigerlake: Enable CNVi through dev_enabled
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39465/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39465/1/src/soc/intel/tigerlake/fsp...
PS1, Line 154: CnviBtCore
When I checked the code, found that when we have CnviMode set to Auto then we dont need to explicitl […]
Is the value 'auto' equal to 1? Should we have an enumerated value here instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39465
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15a03cc70f12e094badf942dd81f22bd09531051
Gerrit-Change-Number: 39465
Gerrit-PatchSet: 1
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 12 Mar 2020 19:07:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-MessageType: comment