Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39682 )
Change subject: src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI ......................................................................
src/mb/intel/tglrvp: Fix board config flag for TGL-UP4 camera ACPI
Camera ACPI had an incorrect board config flag for TGL-UP4.
BUG=None BRANCH=None TEST=Build and boot TGLRVP-UP3 or UP4. Start camera app and able to capture images.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Ided0e146a9240169d3f1f27a86218ac1a942b899 Signed-off-by: Daniel Kang daniel.h.kang@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39682 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Wonkyu Kim: Looks good to me, approved Daniel Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl index 9cb8817..de26fd9 100644 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -390,10 +390,10 @@ CTXS(GPP_H12)
/* Pull PWREN high */ -#if CONFIG_BOARD_INTEL_TIGERLAKE_RVPY - STXS(GPP_E22) +#if CONFIG(BOARD_INTEL_TGLRVP_UP4) + STXS(GPP_E22) #else - STXS(GPP_R6) + STXS(GPP_R6) #endif Sleep(2) /* reset pulse width */
@@ -416,8 +416,8 @@ CTXS(GPP_H12)
/* Pull PWREN low */ -#if CONFIG_BOARD_INTEL_TIGERLAKE_RVPY - CTXS(GPP_E22) +#if CONFIG(BOARD_INTEL_TGLRVP_UP4) + CTXS(GPP_E22) #else CTXS(GPP_R6) #endif