Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35623 )
Change subject: TEST-ONLY: add support anx7625 driver ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35623/2/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/35623/2/src/drivers/analogix/anx762... PS2, Line 272: *m = pixelclock * 599LL / 600;
@jitao: fixed an overflow bug here
Ack
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... File src/drivers/analogix/anx7625/anx7625.c:
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 70: BIOS_INFO
BIOS_ERROR
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 70: read
"%s: read i2c...", __func__, ...
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 87: BIOS_INFO
BIOS_ERR, "%s" ... __func__ […]
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 140: 150
comment why this is 150 (or make a named constant instead)
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 746: ANXGPIO
Move this to a Kconfig, and do […]
Done
https://review.coreboot.org/c/coreboot/+/35623/3/src/drivers/analogix/anx762... PS3, Line 948:
remove the extra new lines
Done