Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36385 )
Change subject: ec/lenovo/h8: Add a config to indicate whether dock init is needed ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36385/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36385/3//COMMIT_MSG@18 PS3, Line 18: between h8_mainboard_init_dock() and h8_enable() should be considered.
Mainboard ops precede all others, so that won't work.
What would be the issue in doing so?
https://review.coreboot.org/c/coreboot/+/36385/2/src/ec/lenovo/h8/h8.c File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/c/coreboot/+/36385/2/src/ec/lenovo/h8/h8.c@357 PS2, Line 357: #if CONFIG(H8_DOCK_INIT)
The H8_DOCK_INIT could be treated as transitional, eliminating empty h8_mainboard_init_dock() declar […]
Looking at boards that need dock init here (x200, x201, t410) I don't think it matters if it's done in before h8_enable. After all doing it early on some boards where dock init is even more involving (LPC to LPC bridge) works, so...