Hello build bot (Jenkins), Marc Jones, Patrick Georgi, Martin Roth, Jonathan Zhang, insomniac, Jingle Hsu, Angel Pons, Rocky Phagura, Morgan Jang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45134
to look at the new patch set (#11).
Change subject: console: Unify overriding console log level with get_option() ......................................................................
console: Unify overriding console log level with get_option()
1. Add config MAINBOARD_OPTIONS and remove CONSOLE_OVERRIDE_LOGLEVEL, it lets mainboard provide overridden function for getting configuration values via get_option(). Currently it's only used for overriding console log level.
2. Remove CONSOLE_LEVEL_CONST and let init_log_level() set log level for all stages. get_log_level() is called by printk so avoid calling an overridden function in case it impacts performance.
Tested=On OCP Delta Lake, coreboot log level can be overridden by mainboard function.
Change-Id: I278e392bed178df7a8cdb90685963c1fedf0bcc4 Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/Kconfig M src/console/Kconfig M src/console/init.c M src/include/console/console.h M src/include/option.h M src/lib/Makefile.inc A src/lib/option.c M src/mainboard/scaleway/tagada/Kconfig 8 files changed, 29 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/45134/11