3 Jul
2019
3 Jul
'19
1:43 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33772 )
Change subject: _WIP_ mb/amd/mandolin: Add Picasso CRB ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33772/2/src/mainboard/amd/mandolin/irq_table... File src/mainboard/amd/mandolin/irq_tables.c:
https://review.coreboot.org/#/c/33772/2/src/mainboard/amd/mandolin/irq_table... PS2, Line 97: printk(BIOS_INFO, "write_pirq_routing_table done.\n"); Prefer using '"%s...", __func__' to using 'write_pirq_routing_table', this function's name, in a string
--
To view, visit https://review.coreboot.org/c/coreboot/+/33772
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b4a78e1eef9f998e1986da1506201eb505822eb
Gerrit-Change-Number: 33772
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 23:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment