Attention is currently required from: Jacob Garber.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38989 )
Change subject: Kconfig,Makefile.inc: Add support for link time optimization
......................................................................
Patch Set 15: Code-Review+1
(1 comment)
Patchset:
PS15:
Patch Set 12:
Patch Set 12:
One thing that worked before for me, doesn't work anymore. I'm not sure if there's any solution for this.
When testing tiny changes, I never did a make clean but just ran `make -j5` to rebuild, where Make just rebuilds the changed source and resolved dependencies automagically. With the LTO patches, this does not seem to work anymore. The final linking step fails: https://paste.xinu.at/gOLYHtjrF4SO68Vam0HfecWreiN4ZJyP8k8GwRk4HTRSfV25v0Cd4u...
Any ideas?
Good catch. The problem is the previous commit that replaces partial linking with thin archives. Trying to find a fix now.
Have you ever found a solution for this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48c31ea8b1b57276125cffdac44c7c16642547ac
Gerrit-Change-Number: 38989
Gerrit-PatchSet: 15
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Martin Roth - Personal
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Sun, 09 Jan 2022 01:54:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment