5 Aug
2020
5 Aug
'20
8:43 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: [WIP]nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40721/6/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/6/src/northbridge/intel/sandy... PS6, Line 346:
nit: Since it's only needed for ECC configs, add an `if (ctrl->ecc_enabled)` check? […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/40721
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9fcc236fbf73f51fe944c6dda5d22ba9d334ec7
Gerrit-Change-Number: 40721
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Kollasch jakllsch@kollasch.net
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 08:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment