[coreboot-gerrit] [XS] Change in coreboot[main]: mtlrvp: add SI_EC region in flash map

[Paul Menzel (Code Review)]

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Krishna P Bhat D.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79209?usp=email )

Change subject: mtlrvp: add SI_EC region in flash map
......................................................................

Patch Set 4:

(10 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79209/comment/a2f4aacf_cbc6496a :
PS4, Line 7: mtlrvp
Please extend the prefix: mb/intel/mtlrvp.

https://review.coreboot.org/c/coreboot/+/79209/comment/7a841b0b_5d50f4a8 :
PS4, Line 7: add SI_EC region in flash map
Add 512 kB SI_EC FMAP region fo MEC1723

https://review.coreboot.org/c/coreboot/+/79209/comment/633fdf77_78f66864 :
PS4, Line 9: MTLRVP
Use “MTLRVP for Chrome OS”?

https://review.coreboot.org/c/coreboot/+/79209/comment/c8b20d44_0c670c41 :
PS4, Line 9: do
does

https://review.coreboot.org/c/coreboot/+/79209/comment/7fb6f649_b1981ba7 :
PS4, Line 9: microchip
Microship

https://review.coreboot.org/c/coreboot/+/79209/comment/5155ae22_c3247976 :
PS4, Line 9: booted with
“booted with”? What do you mean?

https://review.coreboot.org/c/coreboot/+/79209/comment/e6c38cc5_2fd2000f :
PS4, Line 11: Using MEC1723 for chrome helps in RVP BOM convergence.
Sorry, I do not understand what you mean.

https://review.coreboot.org/c/coreboot/+/79209/comment/a6adc9c4_1a5218b4 :
PS4, Line 16: This patch adds SI_EC region similar to windows.
“This patch adds” is redundant in a commit message. Maybe use imperative mood:
> So, add a 512 kB SI_EC region to the flash map similar to RVPs for Microsoft Windows.

Do the boards for Microsoft Windows also use coreboot based firmware?

https://review.coreboot.org/c/coreboot/+/79209/comment/8ca58ebd_1078c81d :
PS4, Line 16: This patch adds SI_EC region similar to windows.
Please add a blank line above to separate paragraphs.

https://review.coreboot.org/c/coreboot/+/79209/comment/a1937276_181c1167 :
PS4, Line 9: MTLRVP booted with microchip EC1723 which do not have an
           : internal flash memory similar to the windows RVP designs.
           : Using MEC1723 for chrome helps in RVP BOM convergence.
           : 
           : EC, AP shares the same external SPI flash. EC ROM will
           : download the EC firmware from external SPI to internal SRAM
           : for execution.
           : This patch adds SI_EC region similar to windows.
Please reflow to use all of the allowed text width of 72 characters per line.