[coreboot-gerrit] [S] Change in coreboot[master]: mb/prodrive/atlas: Enable GPP_B14 buzzer support

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67553 )

(

12 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: mb/prodrive/atlas: Enable GPP_B14 buzzer support
......................................................................

mb/prodrive/atlas: Enable GPP_B14 buzzer support

Per Intel doc 621483, 26.1.1 - NMI_STS_CNT, 8254 timer is required
for Speaker Data output (buzzer) at GPP_B14 NF1, as it is using
8254 timer counter 2 output. However when 8254 timer is used, S0ix
will not work as 8254 has to be gated instead. For further info on
s0ix requirements, refer to Intel doc 610002 (Modern Standby Unified
Checklist).

This CL also disables s0ix because it is not required by the
platform.

Signed-off-by: Lean Sheng Tan 
Change-Id: Ib5e7787a47509ed09818d8515d21a80196fb1ec6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67553
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/prodrive/atlas/Kconfig
M src/mainboard/prodrive/atlas/devicetree.cb
2 files changed, 35 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/prodrive/atlas/Kconfig b/src/mainboard/prodrive/atlas/Kconfig
index 814c1e0..3900f4d 100644
--- a/src/mainboard/prodrive/atlas/Kconfig
+++ b/src/mainboard/prodrive/atlas/Kconfig
@@ -54,6 +54,15 @@
 config NO_POST
    default y

+config ENABLE_BUZZER_SUPPORT
+	bool "Enable Buzzer support"
+	default y
+	select USE_LEGACY_8254_TIMER
+	help
+	  8254 timer is required for buzzer support on GPP_B14 (based on Intel doc 621483,
+	  26.1.1 - NMI_STS_CNT). However since 8254 timer clock gating has to be enabled for
+	  S0ix support, enabling buzzer will disable s0ix.
+
 config PCIEXP_DEFAULT_MAX_RESIZABLE_BAR_BITS
    int
    default 32
diff --git a/src/mainboard/prodrive/atlas/devicetree.cb b/src/mainboard/prodrive/atlas/devicetree.cb
index 0d91bb6..c90c69c 100644
--- a/src/mainboard/prodrive/atlas/devicetree.cb
+++ b/src/mainboard/prodrive/atlas/devicetree.cb
@@ -17,6 +17,9 @@
    # SaGv Configuration
    register "sagv" = "CONFIG(ATLAS_ENABLE_SAGV) ? SaGv_Enabled : SaGv_Disabled"

+	# Disable S0ix
+	register "s0ix_enable" = "0"
+
    # Display configuration (4 DPs)
    register "ddi_ports_config" = "{
    	[DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC,