Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40946 )
Change subject: nb/intel/sandybridge/raminit: Add ECC debug code ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40946/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40946/1//COMMIT_MSG@12 PS1, Line 12: * ECC scrubbing must happen after dram_dimm_set_mapping() Is this about the debug code?
https://review.coreboot.org/c/coreboot/+/40946/1//COMMIT_MSG@13 PS1, Line 13: * Move method out of try_init_dram_ddr3() This is a result of the second point, right?
https://review.coreboot.org/c/coreboot/+/40946/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/40946/1/src/northbridge/intel/sandy... PS1, Line 385: 4096 Assuming channels might be interleaved at this point, this would likely only test a single channel, maybe even only a single rank. It really depends on "what could possibly go wrong?", which addresses make sense to test.
Some test ist better than no test at all, though.