Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_RUNNING_FAFT setting flag ......................................................................
Patch Set 22:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36518/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36518/21//COMMIT_MSG@7 PS21, Line 7: VB2_GBB_FLAG_FAFT_KEY_OVERIDE
No, the flag was actually spelled like that. […]
Done
https://review.coreboot.org/c/coreboot/+/36518/21//COMMIT_MSG@7 PS21, Line 7: trogdor: QCSDI loading depends on VB2_GBB_FLAG_FAFT_KEY_OVERIDE setting
Please make that a statement about the change, and use imperative mood.
Done
https://review.coreboot.org/c/coreboot/+/36518/21/src/soc/qualcomm/common/qc... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/21/src/soc/qualcomm/common/qc... PS21, Line 168:
This should only have a single indent. […]
Done
https://review.coreboot.org/c/coreboot/+/36518/21/src/soc/qualcomm/common/qc... PS21, Line 227: qup_spi_init(QUPV3_1_SE0, 1010 * KHz); /* H1 SPI */
One of the QC engineer working on this HACK patch
Done