Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44039 )
Change subject: mb/google/volteer: Use device aliases ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44039/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/2/src/mainboard/google/voltee... PS2, Line 388: device ref tbt_dma0 on
nit: tbt_dma0 should be between north_xhci and cnvi_bt
Done
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... PS5, Line 22: device pci 07.0 off end # TBT_PCIe0 0x9A23 : device pci 07.1 off end # TBT_PCIe1 0x9A25
Not addressed?
Done
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... PS5, Line 29: device pci 07.0 off end # TBT_PCIe0 0x9A23 : device pci 07.1 off end # TBT_PCIe1 0x9A25
Same here.
Done
https://review.coreboot.org/c/coreboot/+/44039/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
PS3:
Heh yeah, this patch started in July... a lot of new boards have come up since then. Will update.
Done
https://review.coreboot.org/c/coreboot/+/44039/5/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chipset.cb:
PS5:
For sure...
Done
https://review.coreboot.org/c/coreboot/+/44039/9/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chipset.cb:
PS9:
Another bad rebase?
Sorry, been that kind of day