Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30754 )
Change subject: mb/google/poppy/variant/atlas: enable USB acpi
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Any reason not to add the USB3 devices?
The purpose of this patch to add a GPIO for rfkill operation. Not sure about the ask for USB3.
It is more about completeness, if you are going to fill out the USB2 you might as well add the USB3 entries. Otherwise people might see this and think it is complete.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30754
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I411ef707782655361bd1b8ac2b914b8ae64defeb
Gerrit-Change-Number: 30754
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:05:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment