Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62472 )
Change subject: soc/medaitek/mt8186: set pin drive strength to 8mA for NOR
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8186/spi.c:
https://review.coreboot.org/c/coreboot/+/62472/comment/b3c8fe28_4f55488f
PS4, Line 156: printk(BIOS_WARNING, "%s: failed to set pin drive for %d\n",
it still works for community between SoC to NOR, but the waveform is not correct […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b6e37b0f7d4207ea35f11394d25ad1e096ac01a
Gerrit-Change-Number: 62472
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 01 Mar 2022 12:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment