Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33418 )
Change subject: soc/intel/fsp_broadwell_de: Implement SystemAgent TSEG functions ......................................................................
Patch Set 7: Code-Review+2
(5 comments)
I broke master once again. I will address the issues with follow-up instead of reverting bunch of stuff.
https://review.coreboot.org/c/coreboot/+/33418/7/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/broadwell_de.h:
https://review.coreboot.org/c/coreboot/+/33418/7/src/soc/intel/fsp_broadwell... PS7, Line 21: uintptr_t sa_get_tseg_base(void);
<types. […]
Ack
https://review.coreboot.org/c/coreboot/+/33418/7/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/memmap.c:
https://review.coreboot.org/c/coreboot/+/33418/7/src/soc/intel/fsp_broadwell... PS7, Line 33: uintptr_t sa_get_tseg_base(void)
<types. […]
Ack
https://review.coreboot.org/c/coreboot/+/33418/7/src/soc/intel/fsp_broadwell... PS7, Line 39: }
<commonlib/helpers. […]
Ack
https://review.coreboot.org/c/coreboot/+/33418/7/src/soc/intel/fsp_broadwell... PS7, Line 48: /* Lower 20bit of TSEG_LIMIT are don't care, need to add 1MiB */
That could have been ALIGN_UP(limit, 1 * MiB) for the same result?
Ack
https://review.coreboot.org/c/coreboot/+/33418/3/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/ramstage.c:
https://review.coreboot.org/c/coreboot/+/33418/3/src/soc/intel/fsp_broadwell... PS3, Line 95: *
Add spaces around the operator.
Ack