Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )
Change subject: soc/intel/common: Add support for LPSS UART in ACPI mode
......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40405/21/src/soc/intel/common/block...
File src/soc/intel/common/block/uart/chip.h:
https://review.coreboot.org/c/coreboot/+/40405/21/src/soc/intel/common/block...
PS21, Line 1: SPDX-License-Identifier: GPL-2.0-only */
: #include <stdint.h>
maybe an empty line in between?
Jenkins seems not to care.
https://review.coreboot.org/c/coreboot/+/40405/21/src/soc/intel/common/block...
PS21, Line 3: device/pci_ids.h
not used
It is. See commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I838d16322be38f5421c1f63b457a0af552e0ed96
Gerrit-Change-Number: 40405
Gerrit-PatchSet: 21
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 12 Aug 2020 06:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment