[coreboot-gerrit] Change in ...coreboot[master]: mb/google/laser: Disable touch screen device that according to SKU ID

[Peichao Li (Code Review)]

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31428 )

Change subject: mb/google/laser: Disable touch screen device that according to SKU ID
......................................................................

Patch Set 5: Code-Review+1
> Patch Set 4:
> > Patch Set 3:
> > > Patch Set 3:
> > >
> > > (2 comments)
> >
> > Hi Jett,
> > Sorry, I don't think so, since as I know Laser and phaser is no different on the firmware section, SKU ID 1 point to phaser clamshell(100e), SKU ID 6 point to Laser14 clamshell. So I think this logic is correct.
>
> I think Jett meant that having helper function something like:
>
> bool is_touchscreen_sku(int sku_id)
> {
>     if ((sku_id == 1) || (sku_id == 6))
>         return false;
> return true;
>
> }
>
> Then you won't need to add checks in two different places.

Catch your point, add function like below：

bool no_touchscreen_sku(uint32_t sku_id)
{
        if ((sku_id == 1) || (sku_id == 6))
                return true;
        else
                return false;
}
Please kindly take a look.

Thanks