Attention is currently required from: Lance Zhao, Raul Rangel, Tim Wawrzynczak.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63613 )
Change subject: src/acpi/device: Early return in _ON if device already enabled
......................................................................
Patch Set 4:
(2 comments)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/63613/comment/ce05e7a5_0fd6f42a
PS3, Line 675: *
nit: space
Done
https://review.coreboot.org/c/coreboot/+/63613/comment/272ec81d_f3c07a6e
PS3, Line 681: ((
Only 1 `(`?
There are 2 `((` in the generated ACPI code:
```
Method (_ON, 0, Serialized) // _ON_: Power On
{
Local0 = _STA ()
If ((Local0 == One))
{
Return (Zero)
}
_SB.CTXS (0x84)
Sleep (0x01F4)
}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63613
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13aa41766555953b86eded4c72e3b317fe6db5c8
Gerrit-Change-Number: 63613
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 13 Apr 2022 20:45:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment