Hello Aaron Durbin, Patrick Rudolph, Julius Werner, Subrata Banik, Duncan Laurie, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35075
to look at the new patch set (#3).
Change subject: drivers/i2c/generic: Support power resource as parent in device tree ......................................................................
drivers/i2c/generic: Support power resource as parent in device tree
This allows supporting an independent power resource for I2C generic devices, so that the power resource configuration can be refactored out of individual drivers and coalesced into a separate one. This helps enable shared power resources in the future.
Instead of:
device pci 00.0 on chip drivers/i2c/generic register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO0)" register "reset_enable_delay_ms" = "100" ... device i2c 00 on end end
chip drivers/i2c/generic register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO0)" register "reset_enable_delay_ms" = "2" ... device i2c 01 on end end end
You can then write:
device pci 00.0 on chip drivers/generic/power_resource register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO0)" register "reset_enable_delay_ms" = "100" device generic 0 on chip drivers/i2c/generic register ... device i2c 00 on end end chip drivers/i2c/generic register ... device i2c 01 on end end end end end
Change-Id: I7554ab4fef88ffea0d3423ea27bb18a56b7f4de5 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/drivers/i2c/generic/generic.c 1 file changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/35075/3