build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22932 )
Change subject: mb/lenovo/x200: Use lower C-states on battery ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/#/c/22932/11/src/arch/x86/include/arch/acpigen.h File src/arch/x86/include/arch/acpigen.h:
https://review.coreboot.org/#/c/22932/11/src/arch/x86/include/arch/acpigen.h... PS11, Line 354: int get_bat_cst_entries(acpi_cstate_t **); function definition argument 'acpi_cstate_t **' should also have an identifier name
https://review.coreboot.org/#/c/22932/11/src/cpu/intel/speedstep/acpi.c File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/#/c/22932/11/src/cpu/intel/speedstep/acpi.c@182 PS11, Line 182: generate_C_state_entries(cstates, num_cstates); code indent should use tabs where possible
https://review.coreboot.org/#/c/22932/11/src/cpu/intel/speedstep/acpi.c@187 PS11, Line 187: num_bat_cstates); line over 80 characters