build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60300 )
Change subject: CB patch-train re-ordered/updated and pushed upstream ......................................................................
Patch Set 1:
(78 comments)
File 0001-google-herobrine-configure-gpio-to-detect-board-ID.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/980c9519_fb8fb81c PS1, Line 21: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/52336c5f_4ae2abe1 PS1, Line 25: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9d6c51f3_bc613a32 PS1, Line 69: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b6a2b64c_42150423 PS1, Line 70: -- trailing whitespace
File 0002-mb-google-herobrine-Initialize-SPI-FW-for-EC-and-TPM.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a1cc0d12_758495f4 PS1, Line 10: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/174bfd12_0cf65ce4 PS1, Line 33: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/bc6940a2_588c573a PS1, Line 38: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/47e92b6f_c9beb12a PS1, Line 66: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/002eef1b_a95daf7f PS1, Line 83: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/ca33d8eb_ca023e15 PS1, Line 90: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/8810c297_1105201d PS1, Line 96: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/273c8675_4fa900c2 PS1, Line 118: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/2b6ee9af_ce6467da PS1, Line 124: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/be39c1e1_14ca6e04 PS1, Line 146: -- trailing whitespace
File 0003-Herobrine-sc7280-Add-support-for-audio.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e3b54c4d_b115427f PS1, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e63f8745_3fa3e8de PS1, Line 26: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/12497d2d_51667337 PS1, Line 40: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/25b270fa_dfbd321f PS1, Line 51: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/6492d8d2_18b22f42 PS1, Line 60: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/3374a5b1_e8d7b782 PS1, Line 69: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/87891dce_b552ae04 PS1, Line 88: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/7e21c341_279b5b14 PS1, Line 92: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/16816a79_2abac92d PS1, Line 94: -- trailing whitespace
File 0004-Herobrine-TPM-Config-Changes-to-support-audio.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e2b879bd_08a94256 PS1, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/7130ce0e_43915c5c PS1, Line 28: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b6ae864f_e1973daa PS1, Line 38: -- trailing whitespace
File 0005-sc7280-enable-bl31-and-SDI-feature-support.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/d95991b9_4f163dc9 PS1, Line 37: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/cf86f442_b0c96085 PS1, Line 62: -- trailing whitespace
File 0006-sc7280-Add-Modem-region-in-memlayout-to-avoid-modem-.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e96614ec_60f28dd1 PS1, Line 29: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a211a50a_5c367f89 PS1, Line 41: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9af7163b_ff347843 PS1, Line 116: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/539b360f_0de46a11 PS1, Line 118: -- trailing whitespace
File 0007-sc7180-Update-video-mode-active-horizontal-vertical-.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/5d1a40e8_f5f28d8b PS1, Line 25: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9a616c90_50aaac06 PS1, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/6f4d42a1_13bc3ccb PS1, Line 42: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/5dcf3263_34b92783 PS1, Line 47: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/297628a2_c55add90 PS1, Line 55: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/71755ac4_7a99b10d PS1, Line 58: -- trailing whitespace
File 0008-src-mainboard-herobrine-Add-support-QUP-FW-for-I2C-a.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b5191600_f10efd5a PS1, Line 41: -- trailing whitespace
File 0009-libpayload-Parse-DDR-Information-through-coreboot-ta.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/bf629bf6_305f484f PS1, Line 8: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/d21a1435_db95ff26 PS1, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b143cde0_f18381d9 PS1, Line 42: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/6c4a814e_08425eec PS1, Line 106: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/54dbfd22_b5435750 PS1, Line 108: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/8505d4d6_d6626696 PS1, Line 116: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/f00efbff_9aeba3ba PS1, Line 155: -- trailing whitespace
File 0010-src-lib-Added-CBMEM-tag-id-to-parse-ddr-information.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/9823ab92_4dc23e1b PS1, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/c2fad40c_590bc32a PS1, Line 26: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/20577f81_256de0f9 PS1, Line 48: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/1abc2f4b_8316f240 PS1, Line 61: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/f8a8c2e1_ecb2e21f PS1, Line 62: -- trailing whitespace
File 0011-soc-Added-dram-information-to-cbmem.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/8e825620_34d9d9e8 PS1, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/fc5db2fc_e4a1c8d5 PS1, Line 25: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/c64bcb08_21a42165 PS1, Line 33: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/cdf2494e_8de79f7e PS1, Line 35: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/7105761b_23825dc7 PS1, Line 66: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a6f2140f_669354a0 PS1, Line 68: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/e46e180f_0fd62a2c PS1, Line 74: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/1ff63b5b_c3387cca PS1, Line 79: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/39b6ed66_8791bff2 PS1, Line 87: -- trailing whitespace
File 0012-HACK-Senor-build-support-HACK.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/4b923844_b527e7a6 PS1, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/21f0d113_ef08518a PS1, Line 34: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/cbdb26f1_f4247e2d PS1, Line 42: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a3c8a4c2_0ce660ff PS1, Line 43: -- trailing whitespace
File 0013-HACK-sc7280-QSIP-SPI-NOR-addressing-mode-for-SKU1-an.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/c5002e06_d95a1577 PS1, Line 11: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/dc025266_9250a42e PS1, Line 73: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/33bb3189_45b4ed90 PS1, Line 87: -- trailing whitespace
File 0014-HACK-Herobrine-Reinit-TPM-INT-GPIO.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/36b6ed74_6d97256f PS1, Line 29: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/2a01f9a0_8c34e637 PS1, Line 41: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/201dce76_928c67ab PS1, Line 47: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/84a0f667_a8199589 PS1, Line 60: -- trailing whitespace
File 0015-HACK-Herobrine-Reinit-TPM-INT-gpio-after-qclib-execu.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/22fe60db_36386483 PS1, Line 18: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/20031f72_a7038fe7 PS1, Line 20: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/3a21fea1_8f0507cf PS1, Line 32: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/88995571_daba585c PS1, Line 35: -- trailing whitespace
File 0016-HACK-herobrine-T32-scripts-working-in-standalone-env.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/5d7c608b_64d2aa07 PS1, Line 21: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/b2972b07_5974275a PS1, Line 154: -- trailing whitespace
File 0017-HACK-trogdor-optimize-coreboot.rom-for-T32-flash-scr.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136043): https://review.coreboot.org/c/coreboot/+/60300/comment/a1b8aaaf_bf8ed73b PS1, Line 95: -- trailing whitespace