[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Construct BERT region from machine check

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28477 )

Change subject: amd/stoneyridge: Construct BERT region from machine check
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c
File src/soc/amd/stoneyridge/mca.c:

https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@47
PS2, Line 47: 1 * 
?

https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@117
PS2, Line 117: 	if (!IS_ENABLED(CONFIG_ACPI_BERT))
             : 		return;
why put this here instead of around the call?

https://review.coreboot.org/#/c/28477/2/src/soc/amd/stoneyridge/mca.c@141
PS2, Line 141: goto failed;
Can we end up with a half-filled-in table?  Will that cause issues on the reporting side?  Would it be better to generate it somewhere else, then copy the full entry into the table if there's size?