[coreboot-gerrit] Change in coreboot[master]: fw_config: Convert fw_config to a 64-bit field

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45939 )

Change subject: fw_config: Convert fw_config to a 64-bit field
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45939/9/util/sconfig/main.c 
File util/sconfig/main.c:

https://review.coreboot.org/c/coreboot/+/45939/9/util/sconfig/main.c@456 
PS9, Line 456: uint64_t value
> Upgrading FW_CONFIG in general to 64-bit support means that when FW_CONFIG is supplied from CBFS, devtree won't limit you to dealing with a 32-bit field 😊 so regardless of fw_source vs. SSFC-as-upper-32-bits, I think the 64-bit support here is needed for that reason anyway

I agree. Moving to 64 bits for FW_CONFIG is independent of how it is really organized in CBI or CBFS. I was just pointing out that we might have to add some more support in sconfig if we have to support 32-bit SSFC + 32-bit FW_CONFIG in devicetree representation in the future.