Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce and use DEFAUL BARs_ADDRESS symbols ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/14/src/Kconfig@525 PS14, Line 525: .bars Why does the order matter? The new symbols don't have a prompt, hence `menuconfig` wouldn't get confused, would it? Can't we simply name it `src/northbridge/intel/common/Kconfig` then we wouldn't need the additional line here.
https://review.coreboot.org/c/coreboot/+/45610/14/src/northbridge/intel/comm... File src/northbridge/intel/common/Kconfig.bars:
https://review.coreboot.org/c/coreboot/+/45610/14/src/northbridge/intel/comm... PS14, Line 3: DEFAULT_ It's not a default, it is the effective address that will be used. The DEFAULT_ prefix of the macros might have had a historical meaning but is rather irritating, hence please don't copy it here (but keep the macro names for now, so we don't have to change all the C code).