Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37405 )
Change subject: soc/intel/bsw/gpio.h: Drop unused values
......................................................................
Patch Set 4:
Patch Set 4: Code-Review+2
What a mess! (even after this change ^^)
Thanks for the review ^^
If I find some time to finish porting the HP Molokai (Quanta N91A), I'll try to clean this up some more.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c437f34902400022ac6a5e95ff6168545ca557f
Gerrit-Change-Number: 37405
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Dec 2019 17:41:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment