[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/dedede/var/boxy: Add wait for HPD function

[Reka Norman (Code Review)]

Attention is currently required from: Joey Peng.

Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )

Change subject: mb/google/dedede/var/boxy: Add wait for HPD function
......................................................................

Patch Set 1:

(2 comments)

File src/mainboard/google/dedede/variants/boxy/ramstage.c:

https://review.coreboot.org/c/coreboot/+/78146/comment/0fbed1dd_e25bf3d2 :
PS1, Line 68: google_chromeec_wait_for_displayport
I just tested on dibbi and this always returns an error (-1) because EC_CMD_USB_PD_GET_AMODE is no longer implemented in TCPMv2 (https://crrev.com/c/4221975). I'm working on finding a solution.

https://review.coreboot.org/c/coreboot/+/78146/comment/07c9e212_b5606e04 :
PS1, Line 69: wait_for_hpd(GPIO_USB_C0_HPD, display_timeout_ms);
If only C1 or HDMI is connected, I think this will always time out and add 3s to boot time. Have you tested these cases?