Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36273 )
Change subject: lib/cbmem_top: Add a common cbmem_top implementation
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36273/9/src/lib/Kconfig
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/36273/9/src/lib/Kconfig@27
PS9, Line 27: config RAMSTAGE_CBMEM_TOP_ARG
nit: Does this need a new Kconfig or can we just make the default cbmem_top() implementation __weak and add it unconditionally? (I like to avoid adding boilerplate Kconfigs that every platform from now on will want to select.)
Alternatively, maybe we could turn the logic around and make a CUSTOM_CBMEM_TOP option that all current platforms need to select?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36273
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie767542ee25483acc9a56785ce20a885e9a63098
Gerrit-Change-Number: 36273
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Mon, 28 Oct 2019 21:29:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment