Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36328 )
Change subject: [RFC] Documentation/fsp: Discuss FSP-S issues ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... File Documentation/fsp/fsp-s_discussion.md:
https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... PS4, Line 99: This shows that no matter the many options that are implemented in : FSP-S
That wouldn't be what I meant... rather "no matter how many options […]
Ah, understood. I find it difficult to pass, but the native speakers should comment if a change is warranted or not.
https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... PS4, Line 182: in the absence of such a firmware-development utopia,
The idea was to make it clear that we don't expect them to go fully […]
Reading the whole parapgraph, I still think it can be removed. But up to you.
https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... PS4, Line 185: And due to its complex nature, it is no surprise : if memory-controller initialization is kept secret. Understood.
And due to its complex nature with, for example, foreign IP it is harder to open-source the memory-controller initialization.
https://review.coreboot.org/c/coreboot/+/36328/4/Documentation/fsp/fsp-s_dis... PS4, Line 194: or raise legal concerns
let's not open that can of worms...
Done