Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38829 )
Change subject: Documentation: Add new GSoC projects ......................................................................
Patch Set 6:
(8 comments)
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... File Documentation/contributing/project_ideas.md:
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 190: doesn't
don't
Done
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 220: i
spurious `i`: exis*i*ting
Done
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 221: consisting out of
consisting of
Done
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 224: task
plural? tasks
Done
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 228: last test
Should the results of previous tests be kept around? After reading this, it is unclear to me.
Done
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 234: working?
Note that, if a board is not working, then some of the elements below might not be obtainable.
Done
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 235: commit hash
This has a rather nasty problem: it makes reports done using out-of-tree patches, such as when addin […]
I see that this problem exists, but can't be easily fixed. You'd need to add a whitelist of commits, or at least verify if it's in the master repo. I'd say that is an optional task or something to be done afterwards.
https://review.coreboot.org/c/coreboot/+/38829/6/Documentation/contributing/... PS6, Line 242: Not required
Well, one would have to collect all the requirements that must be satisfied in order to design the d […]
Done