Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32283
Change subject: soc/intel/../../timer: Calculate TSC frequency based on CPUID 0x15 ......................................................................
soc/intel/../../timer: Calculate TSC frequency based on CPUID 0x15
This patch ensures to follow Intel SDM Vol 3B Sec 18.7.3 to calculate norminal TSC frequency.
As per SDM recommendation: For any processor in which CPUID.15H is enumerated and MSR_PLATFORM_INFO[15:8] (which gives the scalable bus frequency) is available, a more accurate frequency can be obtained by using CPUID.15H
BUG=b:129839774 TEST=Calculate TSC frequency using below methods 1. TSC freq calculated based on MSR 0xCE tsc: Detected 1600.000 MHz processor
2. TSC freq calculated based on CPUID 0x15 tsc: Detected 1612.800 MHz TSC
Method 2 actually reduce ~25mSec of boot performance time.
Change-Id: I9ff4b9159a94e61b7e634bd6095f7cc6d7df87c7 Signed-off-by: Subrata Banik subrata.banik@intel.com --- A src/arch/x86/include/arch/intel-family.h M src/soc/intel/common/block/timer/timer.c 2 files changed, 161 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/32283/1
diff --git a/src/arch/x86/include/arch/intel-family.h b/src/arch/x86/include/arch/intel-family.h new file mode 100644 index 0000000..632e24c --- /dev/null +++ b/src/arch/x86/include/arch/intel-family.h @@ -0,0 +1,86 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef ARCH_INTEL_FAMILY_H +#define ARCH_INTEL_FAMILY_H + +#define INTEL_CORE_YONAH 0x0E + +#define INTEL_CORE2_MEROM 0x0F +#define INTEL_CORE2_MEROM_L 0x16 +#define INTEL_CORE2_PENRYN 0x17 +#define INTEL_CORE2_DUNNINGTON 0x1D + +#define INTEL_NEHALEM 0x1E +/* Auburndale / Havendale */ +#define INTEL_NEHALEM_G 0x1F +#define INTEL_NEHALEM_EP 0x1A +#define INTEL_NEHALEM_EX 0x2E + +#define INTEL_WESTMERE 0x25 +#define INTEL_WESTMERE_EP 0x2C +#define INTEL_WESTMERE_EX 0x2F + +#define INTEL_SANDYBRIDGE 0x2A +#define INTEL_SANDYBRIDGE_X 0x2D +#define INTEL_IVYBRIDGE 0x3A +#define INTEL_IVYBRIDGE_X 0x3E + +#define INTEL_HASWELL_CORE 0x3C +#define INTEL_HASWELL_X 0x3F +#define INTEL_HASWELL_ULT 0x45 +#define INTEL_HASWELL_GT3E 0x46 + +#define INTEL_BROADWELL_CORE 0x3D +#define INTEL_BROADWELL_GT3E 0x47 +#define INTEL_BROADWELL_X 0x4F +#define INTEL_BROADWELL_XEON_D 0x56 + +#define INTEL_SKYLAKE_MOBILE 0x4E +#define INTEL_SKYLAKE_DESKTOP 0x5E +#define INTEL_SKYLAKE_X 0x55 +#define INTEL_KABYLAKE_MOBILE 0x8E +#define INTEL_KABYLAKE_DESKTOP 0x9E +#define INTEL_CANNONLAKE_MOBILE 0x66 +#define INTEL_ICELAKE_MOBILE 0x7E + +/* "Small Core" Processors (Atom) */ + +#define INTEL_ATOM_PINEVIEW 0x1C +#define INTEL_ATOM_LINCROFT 0x26 +#define INTEL_ATOM_PENWELL 0x27 +#define INTEL_ATOM_CLOVERVIEW 0x35 +#define INTEL_ATOM_CEDARVIEW 0x36 +/* BayTrail/BYT / Valleyview */ +#define INTEL_ATOM_SILVERMONT1 0x37 +/* Avaton/Rangely */ +#define INTEL_ATOM_SILVERMONT2 0x4D +/* CherryTrail / Braswell */ +#define INTEL_ATOM_AIRMONT 0x4C +/* Tangier */ +#define INTEL_ATOM_MERRIFIELD 0x4A +/* Anniedale */ +#define INTEL_ATOM_MOOREFIELD 0x5A +#define INTEL_ATOM_GOLDMONT 0x5C +/* Goldmont Microserver */ +#define INTEL_ATOM_DENVERTON 0x5F +#define INTEL_ATOM_GEMINI_LAKE 0x7A + +/* Xeon Phi */ + +/* Knights Landing */ +#define INTEL_XEON_PHI_KNL 0x57 +/* Knights Mill */ +#define INTEL_XEON_PHI_KNM 0x85 + +#endif /* ARCH_INTEL_FAMILY_H */ diff --git a/src/soc/intel/common/block/timer/timer.c b/src/soc/intel/common/block/timer/timer.c index 1298885..a7ff171 100644 --- a/src/soc/intel/common/block/timer/timer.c +++ b/src/soc/intel/common/block/timer/timer.c @@ -1,7 +1,7 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2017 Intel Corporation. + * Copyright (C) 2017-2019 Intel Corporation. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -13,12 +13,84 @@ * GNU General Public License for more details. */
+#include <arch/intel-family.h> +#include <cpu/cpu.h> #include <cpu/x86/msr.h> #include <cpu/x86/tsc.h> #include <intelblocks/msr.h>
+static int get_processor_model(void) +{ + union cpuid_01 { + uint32_t eax; + struct { + unsigned stepping_id : 4; + unsigned model : 4; + unsigned family : 4; + unsigned reserved1 : 4; + unsigned ext_model : 4; + unsigned ext_family : 8; + unsigned reserved2 : 4; + } b; + }; + + union cpuid_01 eax_value; + + eax_value.eax = cpuid_eax(1); + + return (eax_value.b.ext_model << 4) | eax_value.b.model; +} + +/* + * Nominal TSC frequency = "core crystal clock frequency" * EBX/EAX + * + * Time Stamp Counter + * CPUID Initial EAX value = 0x15 + * EAX Bit 31-0 : An unsigned integer which is the denominator of the + * TSC/"core crystal clock" ratio + * EBX Bit 31-0 : An unsigned interger which is the numerator of the + * TSC/"core crystal clock" ratio + * ECX Bit 31-0 : An unsigned integer which is the nominal frequency of the + * core crystal clock in Hz. + * EDX Bit 31-0 : Reserved = 0 + * + * Refer to Intel SDM Jan 2019 Vol 3B Section 18.7.3 + */ unsigned long tsc_freq_mhz(void) { - msr_t msr = rdmsr(MSR_PLATFORM_INFO); - return (CONFIG_CPU_BCLK_MHZ * ((msr.lo >> 8) & 0xff)); + unsigned int core_crystal_nominal_freq; + struct cpuid_result cpuidr; + + /* CPUID 15H TSC/Crystal ratio, plus optionally Crystal Hz */ + cpuidr = cpuid(0x15); + + if (!cpuidr.ebx || !cpuidr.eax) + return 0; + + core_crystal_nominal_freq = cpuidr.ecx / 1000; + + if (!core_crystal_nominal_freq) { + switch (get_processor_model()) { + case INTEL_SKYLAKE_MOBILE: + case INTEL_SKYLAKE_DESKTOP: + case INTEL_KABYLAKE_MOBILE: + case INTEL_KABYLAKE_DESKTOP: + case INTEL_CANNONLAKE_MOBILE: + case INTEL_ICELAKE_MOBILE: + /* 24.0 MHz */ + core_crystal_nominal_freq = 24000; + break; + case INTEL_ATOM_DENVERTON: + /* 25.0 MHz */ + core_crystal_nominal_freq = 25000; + break; + case INTEL_ATOM_GOLDMONT: + case INTEL_ATOM_GEMINI_LAKE: + /* 19.2 MHz */ + core_crystal_nominal_freq = 19200; + break; + } + } + + return (core_crystal_nominal_freq * cpuidr.ebx / cpuidr.eax) / 1000; }