Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36168 )
Change subject: soc/intel/common: Make native and FSP-T CAR init mutually exclusive
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36168/9/src/soc/intel/common/block/...
File src/soc/intel/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36168/9/src/soc/intel/common/block/...
PS9, Line 9: postcar-$(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU) += cpulib.c
Please mention this drop in the commit message.
Done
https://review.coreboot.org/c/coreboot/+/36168/9/src/soc/intel/common/block/...
PS9, Line 2: bootblock-$(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU)+= car/cache_as_ram_fsp.S
missing space before +=
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie723412dcf09151cdbb41e357ad9c2e4f393cb47
Gerrit-Change-Number: 36168
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Tue, 05 Nov 2019 12:42:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment