Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34890 )
Change subject: util/superiotool: default to using the first discovered chip and exit (let's fix false positives so this isn't necessary); put aspeed in the appropriate execution order to prevent false positives.
......................................................................
Patch Set 1: Code-Review-1
there are systems with more than one super IO chip. I'd strongly prefer fixing the underlying issue than implementing some workaround to hide it, that causes other issues
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I220b87a449a9efbaa4a77ad5ae837ffcdced9605
Gerrit-Change-Number: 34890
Gerrit-PatchSet: 1
Gerrit-Owner: Matt Parnell
mparnell@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Matt Parnell
mparnell@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Aug 2019 05:21:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment