Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
For some reason rPGA989 selects SSE, whereas FCBGA1023 selects SSE2.
SSE2 select SSE. The concept of sockets make no sense anymore since ironlake, because the memory controller was moved on the CPU package, hence removing mixing and matching of CPU/NB/SB. Feel free to remove them like on haswell.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfcf2f0ebbb24c6c2f7a4f2ca5217c0f38f82dde
Gerrit-Change-Number: 31002
Gerrit-PatchSet: 1
Gerrit-Owner: James
jye836@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: James
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Jan 2019 11:50:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment