James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31002
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
mb/lenovo/x131e: correct CPU socket
Change-Id: Ibfcf2f0ebbb24c6c2f7a4f2ca5217c0f38f82dde Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/31002/1
diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index ccdff7c..299a470 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -18,7 +18,7 @@ register "gpu_pch_backlight" = "0x11551155"
device cpu_cluster 0x0 on - chip cpu/intel/socket_rPGA989 + chip cpu/intel/socket_FCBGA1023 device lapic 0x0 on end end chip cpu/intel/model_206ax
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
Patch Set 1: Code-Review+1
For some reason rPGA989 selects SSE, whereas FCBGA1023 selects SSE2.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
For some reason rPGA989 selects SSE, whereas FCBGA1023 selects SSE2.
SSE2 select SSE. The concept of sockets make no sense anymore since ironlake, because the memory controller was moved on the CPU package, hence removing mixing and matching of CPU/NB/SB. Feel free to remove them like on haswell.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
Patch Set 1:
You probably want to update Kconfig too.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31002/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31002/1//COMMIT_MSG@8 PS1, Line 8: Please mention, that sockets do not make much sense, and therefore it should be only a cosmetic change, if I am not mistaken.
James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
Patch Set 1:
I'm going to abandon this change in favour of https://review.coreboot.org/c/coreboot/+/31031
James has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31002 )
Change subject: mb/lenovo/x131e: correct CPU socket ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
James (Code Review)
-
Paul Menzel (Code Review)