Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34581 )
Change subject: mb/google/kohaku: Enable stylus pen device ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@9 PS1, Line 9: Enabling stylus pen device and pen detection event. Please describe the changes you are marking as part of this CL.
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@10 PS1, Line 10: What about pen eject? You added gpio_keys node, but no mention about the change.
https://review.coreboot.org/c/coreboot/+/34581/1//COMMIT_MSG@13 PS1, Line 13: TEST=Verified pen input operation and pen detection event Did pen eject work to: 1. Show the stylus tools on eject 2. Hide the stylus tools on insert 3. Wake from pen eject from S0ix and S3 (Did the eventlog have right information?) 4. No wake by pen insert from S0ix and S3.
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 49: Why was this removed? Is it not required anymore?
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 27: 1 Note: This should be set to 0 if you figure out that the reset GPIO needs to be part of power sequencing in ACPI power resource.
https://review.coreboot.org/c/coreboot/+/34581/1/src/mainboard/google/hatch/... PS1, Line 43: NONE INVERT
https://review.coreboot.org/c/coreboot/+/34581/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/34581/2/src/mainboard/google/hatch/... PS2, Line 27: 1
On testing that, keeping this as 0 and enabling the reset_gpio doesn't seem to work...
Yeah, it is being tracked at b/137326841 to understand what the real power-on sequencing requirement is w.r.t. reset GPIO.