7 comments:
Patch Set #1, Line 9: Enabling stylus pen device and pen detection event.
Please describe the changes you are marking as part of this CL.
What about pen eject? You added gpio_keys node, but no mention about the change.
Patch Set #1, Line 13: TEST=Verified pen input operation and pen detection event
Did pen eject work to:
1. Show the stylus tools on eject
2. Hide the stylus tools on insert
3. Wake from pen eject from S0ix and S3 (Did the eventlog have right information?)
4. No wake by pen insert from S0ix and S3.
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
Why was this removed? Is it not required anymore?
Note: This should be set to 0 if you figure out that the reset GPIO needs to be part of power sequencing in ACPI power resource.
INVERT
File src/mainboard/google/hatch/variants/kohaku/gpio.c:
On testing that, keeping this as 0 and enabling the reset_gpio doesn't seem to work...
Yeah, it is being tracked at b/137326841 to understand what the real power-on sequencing requirement is w.r.t. reset GPIO.
To view, visit change 34581. To unsubscribe, or for help writing mail filters, visit settings.