Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162 )
Change subject: security/tpm: support compiling in multiple TPM drivers ......................................................................
Patch Set 1:
(2 comments)
File src/security/tpm/tis.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162139): https://review.coreboot.org/c/coreboot/+/69162/comment/7a4e6fa4_303a91dd PS1, Line 101: #define __tis_driver __attribute__((used, __section__(".rodata.tis_driver"))) Prefer __used over __attribute__((used))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162139): https://review.coreboot.org/c/coreboot/+/69162/comment/7a619fca_b1bd57a0 PS1, Line 101: #define __tis_driver __attribute__((used, __section__(".rodata.tis_driver"))) Prefer __section(".rodata.tis_driver") over __attribute__((__section__(".rodata.tis_driver")))