Daniel Gröber (dxld) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42112 )
Change subject: spi: Add struct spi_flash_bpbits, a common rep. for block protection ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42112/2/src/include/spi_flash.h File src/include/spi_flash.h:
https://review.coreboot.org/c/coreboot/+/42112/2/src/include/spi_flash.h@73 PS2, Line 73: * srl srp
Do we need to carry this naming distinction through our code? I think Winbond just renamed these at […]
W25Q128JV also has the behaviour I'm documenting here. The new parts with srp/srl have this special (undocumented AFAICS[1]) status register write sequence that makes writing this bit permanent. Normal writes have the behaviour as documented here though.
[1]: Or at least they say: Note: Please contact Winbond for details regarding the special instruction sequence.
I really just wanted to put a note somewhere pointing out the difference in behavour between these two generations of parts. I suppose I could move the tables to winbond_region_to_bpbits instead and remove the bool unions if you prefer.