Attention is currently required from: Frank Wu, John Su, Furquan Shaikh, Martin Roth, Alan Lee, Ivy Jian.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49783 )
Change subject: drivers/generic/bayhub_lv2: Add driver for BayHub lv2
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
File src/drivers/generic/bayhub_lv2/chip.h:
https://review.coreboot.org/c/coreboot/+/49783/comment/f118eef2_1001fe4f
PS8, Line 5: PCI
PCIe?
https://review.coreboot.org/c/coreboot/+/49783/comment/5bfdebf3_4bb5dffb
PS8, Line 7: /* 1 to enable power-saving mode, 0 to disable */
: bool power_saving;
I would rename the option to `enable_power_saving`, and drop the comment
File src/drivers/generic/bayhub_lv2/lv2.h:
https://review.coreboot.org/c/coreboot/+/49783/comment/9f0c0377_e786dd09
PS8, Line 3: PCI
PCIe?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc1340b1a6fe7063d16c8ea16488d6e2b8b308cc
Gerrit-Change-Number: 49783
Gerrit-PatchSet: 8
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Attention: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 15:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment