Attention is currently required from: Annie Chen, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Held, Jincheng Li, Lean Sheng Tan, Nill Ge, Paul Menzel, Shuo Liu, TangYiwei, Tim Chu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78327?usp=email )
Change subject: soc/intel/xeon_sp: Redesign resource allocation
......................................................................
Patch Set 19:
(1 comment)
File src/soc/intel/xeon_sp/spr/ioat.c:
https://review.coreboot.org/c/coreboot/+/78327/comment/1715bd50_75a4ea9a :
PS19, Line 75: HQM_BUS_OFFSET + HQM_RESERVED_BUS
I believe this is one too little now? HQM_BUS_OFFSET gives the number of buses
below HQM, then we need one for HQM and another reserved one.
(on the LHS we have the number of buses available, so on the RHS we want at least
1 for DINO, 2 for CPM and 2 for HQM, so 5. we could also hard-code the 5 to avoid
macro confusion)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78327?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb29c24b71a18e2e092f9d4953d106e6ca0a5fe1
Gerrit-Change-Number: 78327
Gerrit-PatchSet: 19
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Annie Chen
chen.annieet@inventec.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen, Gang C
gang.c.chen@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jincheng Li
jincheng.li@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Annie Chen
chen.annieet@inventec.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 11 Jan 2024 18:40:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment