Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: drivers/vpd: Add a function that reads BIOS version from a VPD variable
......................................................................
Patch Set 6:
Updated the commit message to reflect the special usage for updating BIOS version w/o rebuilding from source, it's for internal build and test processes.
If this is simply for testing, I'd say cbfs file would be the better (and more correct) choice than VPD, since VPDs are supposed to be preserved (e.g., no update) during update while CBFS is not (will be updated).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee62ed900095001ffac225fc629b3f2f52045e30
Gerrit-Change-Number: 42029
Gerrit-PatchSet: 6
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jun 2020 04:18:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment