Attention is currently required from: Shuo Liu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81628?usp=email )
Change subject: soc/intel/xeon_sp: Use default soc_get_ioapic_info
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/81628/comment/f2f02181_b79d40e7 :
PS3, Line 93: #if CONFIG(XEON_SP_HAVE_IIO_IOAPIC)
i'd say that moving the code inside the #if block into a separate c file and conditionally add that to the build that depending on CONFIG_XEON_SP_HAVE_IIO_IOAPIC would be a bit cleaner solution
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81628?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ecfba49cd9b4dfbb3f11d58d04d07ea1752a131
Gerrit-Change-Number: 81628
Gerrit-PatchSet: 3
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Comment-Date: Thu, 04 Apr 2024 12:49:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment