Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35882 )
Change subject: soc/intel: sgx: get rid of UEFI-style usage of global variable ......................................................................
Patch Set 4:
(2 comments)
Alternative approach: Move the soc_sgx_enabled() to the soc level where it belonged. You'd only have to query confg->sgx_enabled() once per soc this way. Might even reduce a little more clutter.
https://review.coreboot.org/c/coreboot/+/35882/4/src/soc/intel/skylake/cpu.c File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/35882/4/src/soc/intel/skylake/cpu.c... PS4, Line 460: SOC_INTEL_COMMON_BLOCK_SGX There's an unconditional `select` on this at the soc level.
https://review.coreboot.org/c/coreboot/+/35882/4/src/soc/intel/skylake/cpu.c... PS4, Line 500: SOC_INTEL_COMMON_BLOCK_SGX same here.