Attention is currently required from: Kyösti Mälkki.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44293 )
Change subject: drivers/amd/agesa/s3_mtrr.c: Use a struct over pointer aritmetic
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/amd/agesa/s3_mtrr.c:
https://review.coreboot.org/c/coreboot/+/44293/comment/77f59c52_c6f0959d
PS4, Line 47: mtrr_save->mtrr_phys_mask[i] = rdmsr(MTRR_PHYS_BASE(i));
MTRR_PHYS_MASK(i)
Maybe you want to read BASE() first, althought it does not matter
You are right. It also looks like the default MTRR_DEF_TYPE_MSR is not backup/set?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c6df8951d39695cddd4635360d6407d4d001b0a
Gerrit-Change-Number: 44293
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 18 May 2022 09:20:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment