Hello Karthikeyan Ramasubramanian,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39347
to review the following change.
Change subject: mb/google/dedede: Configure EDP_HPD GPIO ......................................................................
mb/google/dedede: Configure EDP_HPD GPIO
This enables display for use by payload
TEST=Build and boot the mainboard. Ensure that the screens displayed by payload are visible.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I5fcd70623b15ae39954242605e75b2c5ce02ff14 --- M src/mainboard/google/dedede/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/39347/1
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index f11d3a7..a4c9a72 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -42,7 +42,7 @@ /* A16 : EC_AP_USB_C0_HPD */ PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), /* A17 : EDP_HPD */ - PAD_NC(GPP_A17, NONE), + PAD_CFG_NF(GPP_A17, NONE, DEEP, NF1), /* A18 : USB_OC0_N */ PAD_NC(GPP_A18, NONE), /* A19 : PCHHOT_N */